mapbox / mapbox/graph-normalizer
Handle implied oneway tags
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 12
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
When the ways have `junction=roundabout`, that implies that the ways are oneway.
We currently ignore junction tags. Consequently graph-normalizer might output duplicate ways (forward and reverse) for roundabouts, where there should only be a single way.
What should we do when the way we receive has tags `oneway: 0` and `junction: roundabout` ?
@oxidase some matching issues that we have experienced are coming from this bug.
#43 is actually an instance if this bug, so I'm closing the other ticket in favor of this one.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the graph-normalizer logic that handles way tags, especially `junction` and `oneway`. Reproduce a way tagged `junction=roundabout` and `oneway: 0`; done means roundabout ways are not emitted as duplicate forward and reverse ways, with the behavior covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100