`npm run build` should be gated by an option and off by default
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Currently `npm run build` is [run unconditionally](https://github.com/mapbox/gha-public/blob/main/.github/workflows/workflow-npm-oidc-publish.yml#L87-L89), which is redundant for most packages — those that were previously published manually typically have a `prepublishOnly` hook that does all the necessary building on `npm publish`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in .github/workflows/workflow-npm-oidc-publish.yml at lines 87–89, where npm run build currently runs unconditionally. Trace the workflow’s existing options and publish steps, then verify that building is off by default, can be enabled through an option, and does not disrupt npm publish for packages using prepublishOnly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, node.js
- Domain
- ci-cd, release
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100