0.7.1 is a breaking change
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
@kepta I think we should revert 0.7.1 and the change for https://github.com/mapbox/fusspot/issues/39.
The misunderstanding there is that if a property is actually required, that should be made explicit with fusspot.required. In @kellyoung's example where f.assert(f.strictShape({name: f.string}))({}) passes, that's fine name is not required. If name were required, the schema should be changed to f.stripeShape({ name: f.required(f.string)) }).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issue #39 and the changes introduced in 0.7.1, focusing on the strictShape examples and the explicit fusspot.required behavior described here. Determine whether the release changed the intended contract and whether reverting it is still appropriate; done means the decision and affected behavior are reflected in the project.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100