Object-shape validation does not require that the object be a plain object
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
Right now you can't use `shape` or `strictShape` validation on an object that has a special prototype — like, an object that is an instance of a `class`. I don't think there's any need for this restriction: shape validation would be just as handy with non-plain-objects.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation and existing tests for the `shape` and `strictShape` validators. Start by checking how object prototypes are currently handled, then add coverage for class instances and verify that shape validation accepts them while strict-shape behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100