mapbox / mapbox/fontnik

No longer compatible with opentype and pbf

Open
#8 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
56
Forks
13
PR merge metrics
No merged PRs in 30d

Description

The project dependencies aren't tied to a specific version of both **opentype** and **pbf**.
That said, there are a few errors.

e.g., Pbf had some breaking changes. How should the following line be changed to be compatible with the latest version?
`fontstack_pbf.writeMessage(/* glyphs */ 3, glyph_pbf);`

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dependency declarations and the call site containing `fontstack_pbf.writeMessage(/* glyphs */ 3, glyph_pbf);`. Check the breaking changes in the latest pbf and opentype versions and reproduce the reported errors. Done means the dependencies are compatible with current versions and the glyph-writing path works without those errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.