mapbox / mapbox/dyno

Illegal return

Open
#147 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
79
Forks
27
PR merge metrics
No merged PRs in 30d

Description

I'm running into a parsing issue (`Illegal return`) on [line 249](https://github.com/mapbox/dyno/blob/master/bin/cli.js#L249) of cli.js:

```
if (params.command === 'export') {
return dyno.describeTable(function(err, desc) {
if (err) {
console.error(err);
process.exit(1);
}

console.log(cleanDescription(desc));
scan();
});
}
```

I am pretty sure this is because `return` is being used outside of a function. This should probably be refactored.

cc @mapbox/atlas

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in bin/cli.js at line 249 and inspect the surrounding command handling for the export branch. Refactor the control flow so the file parses without an Illegal return while preserving the described export behavior, then verify the CLI no longer reports the parsing error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.