mapbox / mapbox/dbf

solve structure problem

Open
#42 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
42
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `dbf@0.1.4` for the project I'm working on.

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/dbf/src/structure.js b/node_modules/dbf/src/structure.js
index 4b02783..f2b4c0b 100644
--- a/node_modules/dbf/src/structure.js
+++ b/node_modules/dbf/src/structure.js
@@ -55,7 +55,7 @@ module.exports = function structure(data, meta) {
if (f.type == 'N') view.setInt8(32 + i * 32 + 17, 3);
});

- offset = fieldDescLength + 32;
+ var offset = fieldDescLength + 32;

data.forEach(function(row, num) {
// delete flag: this is not deleted
```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review node_modules/dbf/src/structure.js around the structure function and compare the reported diff with the current source. Confirm that the local offset declaration resolves the reported structure problem, then verify the dbf writer still produces the expected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.