tighten equality check in unit tests
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 373
- Forks
- 80
- PR merge metrics
- No merged PRs in 30d
Description
#64 was buggy. The unit tests passed, but in reality the unit tests weren't doing a strict equality check so it was a false pass, https://github.com/Automattic/expect.js. Fixed in #67, but to ensure the unit tests are testing correctly we should tighten the equality test in the unit tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the unit tests related to #64 and the fix in #67, then identify assertions that allow false passes instead of performing strict equality checks. Tighten those assertions and confirm the unit tests still pass while rejecting the previously undetected mismatch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100