Error or null geometry when lng,lat not detected?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 373
- Forks
- 80
- PR merge metrics
- No merged PRs in 30d
Description
In previous versions, this module threw an error when lng,lat were not detected. The documentation suggests this still should happen:
Err is non-falsy if latitude and longitude values cannot be detected or if there are invalid rows in the file.
However, I think commit https://github.com/mapbox/csv2geojson/commit/ee8d854540c5733bbc79c1f7678228988b850dc5 changed this behavior. The module now returns a null geometry. However, that commit did not update the documentation, and it left the relevant test in a strange place, where its description no longer matches its outcome.
So @tmcw I'm wondering which route you think would be best for this module. Should we document and clearly test the actual current behavior — not erroring, instead returning null geometry — or go back to the way things were — erroring?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the current behavior with the documentation and inspect the relevant test identified in commit ee8d854540c5733bbc79c1f7678228988b850dc5. First determine whether missing lng,lat values should produce an error or null geometry. Done means the chosen behavior, documentation, and test description agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100