mapbox / mapbox/concaveman

FeatureRequest: Segments as input

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
724
Forks
84
PR merge metrics
No merged PRs in 30d

Description

Would it be possible to extend concaveman to support segments as input in addition to points?

The use case would be to fix slightly broken complex vector data, where say the boundary lines of a lake don't quite make up a closed polygon.

I was initially thinking converting the lines to points, but I realized that this will cause artifacts in cases where the original segments made a nice crisp edge (say at a jetty), the inner corners will end up mitered by the tolerance amount, which would in my case be significant.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by reviewing concaveman's current point-input API and hull algorithm, then determine how open segments and their endpoints should be represented and processed. Done means segment input is supported without losing crisp edges in cases such as broken lake boundaries and jetties.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.