mapbox / mapbox/cloudfriend

Validate cli tool should accept multi-files or directories

Open
#33 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
74
Forks
10
PR merge metrics
No merged PRs in 30d

Description

A side-effect of https://github.com/mapbox/cloudfriend/pull/31 is that `validate-template cloudformation/*.js` doesn't work anymore. Some ways of mitigating:

1. `validate-template cloudformation/template1.js && validate-template cloudformation/template2.js`
2. Allow `validate-template cloudformation/` and loop over the template in `/bin/validate-template.js`
3. Revert https://github.com/mapbox/cloudfriend/pull/31 to use `--region` instead.

I think I'd prefer option 3, since it's the most compatible with how aws-cli works (which in a way is the godfather convention here).

/cc @rclark @vsmart

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with bin/validate-template.js and review the behavior introduced by pull request #31. Compare the command's current handling of cloudformation/*.js with the issue's preferred aws-cli-compatible approach using --region. Done means validate-template no longer loses the expected multi-file or directory-compatible workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.