Can't pass an object to cf.split
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 74
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
Because of the `toString()` [here](https://github.com/mapbox/cloudfriend/blob/75fa1750e9330aecdd86edeb625fc3a83a4eb266/lib/intrinsic.js#L206), if you pass a object (e.g. a `"Ref"`) to `cf.split()`, it gets turned into `[object Object]`.
```js
> cf.split(',', cf.ref('SomeParameter'))
{ 'Fn::Split': [ ',', '[object Object]' ] }
```
cc @xrwang
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to lib/intrinsic.js around line 206; start there and reproduce the cf.split(',', cf.ref('SomeParameter')) example. Trace how the argument is converted, and consider the work complete when the Ref object is preserved rather than becoming '[object Object]'.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, javascript
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100