mapbox / mapbox/cfn-stack-event-stream
Stream does not complete on ROLLBACK_FAILED
Open
Beginner friendly
Nobody has claimed this yet.
assembly-line
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
When a stack operation fails and the rollback fails as well, the stream should end be completed.
Thus, in line 83 I think you should check for ROLLBACK_FAILED too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at line 83, where stack operation statuses are checked, and compare the handling of ROLLBACK_FAILED with the existing completion condition. Update the condition so a failed rollback ends the stream as completed, then verify that the stream terminates for this status.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, javascript
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100