mapbox / mapbox/assert-http

assert.deepEqual is not strict

Open
#10 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5
Forks
8
PR merge metrics
No merged PRs in 30d

Description

```
// doesn't throw
assert.deepEqual(['32'], [32]);
```

Look into switching to https://github.com/substack/node-deep-equal with `opts.strict`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the shown assert.deepEqual case, then locate the assert.deepEqual implementation in the repository. Compare its behavior with node-deep-equal using opts.strict; done means ['32'] and [32] are no longer considered equal and the relevant test coverage passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.