mapbox / mapbox/MapboxGeocoder.swift

Derive Placemark.scope from place_type

Open
#195 0 comments 0 reactions 1 assignee View on GitHub

@1ec5 is already working on this.

Since Jun 26, 2019.

bug
Dominant language
Swift
Stars
133
Forks
46
No merged PRs in 30d

Description

Placemark.scope is computed by parsing the feature identifier, but this means a placemark can have only one scope. In fact, a Geocoding API result can have multiple scopes, but the remaining scopes are encoded in the place_type property.

https://github.com/mapbox/MapboxGeocoder.swift/blob/ffb6c134b2f91df921f697669614d3ce53af0e70/MapboxGeocoder/MBPlacemark.swift#L184-L188

/ref mapbox/mapbox-java#512
/cc @frederoni @samfader

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.