mapbox / mapbox/MapboxGeocoder.swift
Expected fields do not always appear in the MBGeocodedPlacemark
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 133
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
Using v0.10.0.
If I reverse geocode a point in the water of the San Francisco Bay, "California" does not appear as an administrativeRegion on the MBGeocodedPlacemark. If I print the addressDictionary of the placemark, I see that the name is California, but it is not placed under the state key.
Sample code:
CLLocationCoordinate2D coordinate = CLLocationCoordinate2DMake(37.763778227711242, -122.32790567148118);
MBGeocoder *geocoder = [[MBGeocoder alloc] initWithAccessToken:<token>];
MBReverseGeocodeOptions *options = [[MBReverseGeocodeOptions alloc] initWithCoordinate:coordinate];
[geocoder geocodeWithOptions:options completionHandler:^(NSArray<MBGeocodedPlacemark *> * _Nullable placemarks, NSString * _Nullable attribution, NSError * _Nullable error) {
NSLog(@"%@", [placemarks[0] addressDictionary]);
}];
Output:
{
ISOCountryCode = US;
country = "United States";
formattedAddressLines = (
"United States"
);
name = California;
}
This makes it challenging to properly format and display reverse geocode data that is powered by a dynamic location at run time. If I reverse geocode a location that has a street address, it likely has a state field.
Below is the addressDictionary of a reverse geocode coordinate in downtown San Francisco. The state is now there. (37.794291209161685, -122.412848997168)
{
ISOCountryCode = US;
city = "San Francisco";
country = "United States";
formattedAddressLines = (
"1187 Washington Street",
"San Francisco",
"California 94108",
"United States"
);
name = "Washington Street";
postalCode = 94108;
state = California;
street = "Washington Street";
subAdministrativeArea = "San Francisco";
subLocality = "Nob Hill";
subThoroughfare = 1187;
thoroughfare = "Washington Street";
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MBGeocoder's geocodeWithOptions:completionHandler: flow and the MBGeocodedPlacemark addressDictionary shown in the report. Compare the San Francisco Bay and downtown coordinates, then verify that the expected administrativeRegion/state information is consistently exposed for reverse-geocoded placemarks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c, swift
- Domain
- api, mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100