maoschanz / maoschanz/drawing

Selection options applied when defining it, not changeable afterwards

Open
#583 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement selection
Dominant language
Python
Stars
869
Forks
106
PR merge metrics
No merged PRs in 30d

Description

## Use case

user realizes the 'selection-extract' or the 'selection-color' is wrong. To realize that, they have already defined the selection pixbuf: sadly, those options are applied at the time of the 'define' operation, so the app expects them to unselect, change the value, and start all over again

## Suggested solution

damn idk, i'm at work i don't have time for this, i'll think about that later

grouping the related selection operations with an id, retroactively change the 'define' operation, and rebuild the selection pixbuf from the history in `on_options_changed`??

### Possible drawbacks

huge change to how the selection works = hard as hell = bugs everywhere

### Possible alternatives

no

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the selection-extract and selection-color options through the define operation and on_options_changed. Review how the selection pixbuf and operation history are handled. Done would allow changing these options after defining a selection without requiring the user to unselect and start over, while preserving existing selection behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.