manyuanrong / manyuanrong/sql-builder

readability

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
55
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Readability is very poor in this piece of code…
However, if you remove those unnecessary `else`'s (because you have `return`'s everywhere), the code will become slightly more readable

https://github.com/manyuanrong/sql-builder/blob/2b2b5dea7ce1b3fd37a349446279f6dbef6bb23a/util.ts#L15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open util.ts at the linked line and inspect the surrounding control flow. Remove the unnecessary else branches while preserving the existing return behavior; done means the code is more readable without changing its results.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
databases
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.