Unnecessary line in class Create

Method "setBody" of class "Create" has unnecessary line # 37 (of origin file /phpClient/vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Endpoints/Indices/Create.php).

See comment inside code:

public function setBody($params = null)
{
if (isset($this->index)) {
$columns = [];
if (isset($params['columns'])) {
foreach ($params['columns'] as $name => $settings) {
$column = $name . ' ' . $settings['type'];
if (isset($settings['options']) && count($settings['options']) > 0) {
$column .= ' ' . implode(' ', $settings['options']);
}
$columns[] = $column;
}
}
$options = "";
if (isset($params['settings'])) {
foreach ($params['settings'] as $name => $value) {
$options.=" ".$name." = '".$value."'"; // ##### <----- this line is unneccessary, because the same code lower in "else" block
if (is_array($value)) {
foreach ($value as $v) {
$options.=" ".$name." = '".$v."'";
}
} else {
$options.=" ".$name." = '".$value."'"; // #### <----- the same code
}
}
}
return parent::setBody(['query' => "CREATE TABLE ".
(isset($params['silent']) && $params['silent']===true?' IF NOT EXISTS ':'').
$this->index.
(count($columns)>0?"(".implode(",", $columns).")":" ")
.$options]);
}
throw new RuntimeException('Index name is missing.');
}

Open phpClient/vendor/manticoresoftware/manticoresearch-php/src/Manticoresearch/Endpoints/Indices/Create.php and inspect Create::setBody, especially the settings loop and its generated options. Confirm the resulting CREATE TABLE body remains correct for scalar and array settings, then verify that the redundant behavior identified in the issue is gone.

Written by the indexing model from the issue text.