manticoresoftware / manticoresoftware/manticoresearch-backup

Store config name in meta file on backup and use it on restore

Open
#117 1 comment 0 reactions 1 assignee View on GitHub

@donhardman is already working on this.

Since Jun 20, 2024.

enhancement est::size_S
Dominant language
PHP
Stars
6
Forks
1
Avg merge
4d 6h
Merged PRs (30d)
2

Description

Currently, we are only storing versions when we perform a backup.

However, there is an issue with hardcoded values that we should aim to remove: https://github.com/manticoresoftware/manticoresearch-backup/blob/fa1fecdf149e60248b47e1acfe64cf23d9c83fee/src/Lib/ManticoreBackup.php#L260-L263

To resolve this, we should store meta information and also write the config name during the backup stage, and restore it accordingly. To simplify things, it seems the best idea is to use a single metafile instead of versions and other elements.

This is a breaking change and will make old backups incompatible with the new tool due to changes in the system file name we will use for storing metadata.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.