manticoresoftware / manticoresoftware/manticore-github-issue-search
Show comments on state filter change for those issue state only (JOIN in the demo)
@donhardman is already working on this.
Since May 21, 2024.
- Dominant language
- PHP
- Stars
- 14
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
When we work with filters and search, we can currently filter by the state that only issues and pull requests have. However, when we change the state to open or close, we still search for comments everywhere.
As discussed before, it would be a good idea to also search comments only for the pull requests we filter. To do so, it seems like a great idea to showcase JOIN logic. Basically, we need to search in comments using JOIN logic that belongs to the currently selected states of issues, if any.
Unfortunately, this functionality is currently blocked by the issue https://github.com/manticoresoftware/manticoresearch-php/issues/210.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.