manosim / manosim/django-rest-framework-docs

__get_serializer_class__() method does not works

Open
#123 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
641
Forks
178
PR merge metrics
No merged PRs in 30d

Description

djangorestframework==3.4.0, GenericViewSet. Inherited ViewSet doesn't contents serializer_class property, but method gets serializer_class attribute from parent. I think, that get_serializer_class must have more priotity

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in rest_framework_docs/api_endpoint.py around line 82 and inspect how GenericViewSet serializer information is selected when the inherited ViewSet lacks serializer_class. Confirm the behavior against djangorestframework 3.4.0; the issue is done when get_serializer_class takes precedence over the inherited serializer_class lookup.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.