maniator / maniator/verticopolis

[P3] sprites.test.ts drives every room kind at the retired 11px tile

Open Beginner friendly
#830 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Deferred from the gds-code-review of the room occupant seats fix (PR for #813). Pre-existing, not introduced by that change.

src/render/sprites.test.ts still drives every room kind at the retired 11px tile. Rects of 132x44, 176x44, 220x44 and 88x44 run through drawUnit at lines 162-272: geometry the renderer no longer produces, since the world moved to TILE 10 by FLOOR 45. A suite that exercises sizes the game never renders can pass while the shipped sizes are broken, which is plausibly part of why the #813 under-draws went unnoticed for so long.

The one case #813 touched was moved to roomCapacity.test.ts at the bay's real rect. The rest wants its own sweep: restate each rect as width * TILE by facilityFloors(kind) * FLOOR so the suite follows the world constants instead of pinning history.

Severity low, but it is a live blind spot in a guard suite, not a style nit.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/render/sprites.test.ts, especially the drawUnit cases at lines 162-272, and compare them with the TILE and FLOOR world constants and facilityFloors(kind). Restate each room rectangle using those values, then run the sprites test suite. Done means the cases cover the shipped room dimensions rather than retired 11px geometry.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.