maniator / maniator/verticopolis

[Bug]: Improve click handling for tools mode in main canvas

Open
#824 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Build version

HEAD

What happened?

The build tool mode does not correctly track the mouse activity. e.g. when clicking, it will stay depressed. and it may not show the ghost frame when you expect it to, until you click around.

Steps to reproduce
  1. moving the mouse while mousedown off of the primary canvas area and releasing elsewhere can cause this state to occur.
Browser

Chrome / Chromium

Platform

Desktop

Game mode

Not sure / not applicable

Console errors

Before submitting
  • I checked whether this still reproduces on the latest build at verticopolis.com (fork/local or older-build reports are still welcome).
  • I searched existing issues and this is not a duplicate.

WIP: I have started a patch file but not yet refined it further. Here is the start of the matter. It includes a bit of test suite coverage to deal with this kind of problem.

verticopolis-cursor-fix.patch

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the main canvas tool-mode click and mouse activity handling, then review the attached verticopolis-cursor-fix.patch and its test coverage. Reproduce the issue by moving while holding the mouse button outside the primary canvas and releasing elsewhere in Chrome or Chromium. Done means the tool no longer stays depressed and the ghost frame appears at the expected time.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.