maniator / maniator/verticopolis

[P3] founder-spec-missing: the Ground Floor badge cites a party spec that is not in the repo

Open
#682 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Deferred from the /gds-code-review Acceptance Auditor on PR #633 (Modern rental living, v2.0.0).

Two record gaps around the 2.0 "Ground floor" founder badge and the major version bump:

  1. src/founder.ts:3 and src/ui/splashTemplate.ts:100 cite "Party-ratified (2026-07-23)" and "SPEC/party 2026-07-23" as the authority for the feature, but no such artifact exists under _bmad-output/. The branch's own append-only decision log for this GDD stops at D19 with no entry for the badge. A code comment pointing at a spec that is not in the repo is the same failure mode as a decision log that misdescribes the code: later work trusts it and cannot find it.

  2. Epic 8 and the GDD's Technical Specifications both specify a minor version bump and one player-outcome CHANGELOG line. The branch ships 2.0.0 with three notes. The major bump is defensible under CLAUDE.md ("major for ... a headline milestone") and the three notes are within MAX_NOTES, but neither the epics doc nor the decision log records the deviation.

Fix when picked up: either add the founder spec to _bmad-output/ or repoint the code comments at whatever the real authority is, and record the 2.0 bump decision in the GDD decision log.

/bmad-code-review.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/founder.ts:3 and src/ui/splashTemplate.ts:100, then inspect _bmad-output/ for the cited founder spec and the GDD decision log. Compare Epic 8 and the GDD Technical Specifications with the shipped version and changelog notes. Done means the authority reference is valid and the 2.0 bump deviation is recorded in the decision log.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.