maniator / maniator/verticopolis

[P3] rental-shared-picture-set: Studio and Apartment share one decor set where the spec asks for one each

Open
#681 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Deferred from the /gds-code-review Acceptance Auditor on PR #633 (Modern rental living, v2.0.0).

GDD mechanic 6 and Epic 5 both say: "Each of Studio and Apartment gets its own wall-palette set and decor/picture set."

Walls are per-kind (STUDIO_WALLS, APARTMENT_WALLS at src/render/pixelSprites/residential.looks.ts:39,43), but both kinds pass the same RENTAL_PICTURES (src/render/pixelSprites/residentialRentalSprites.ts:15,19).

The stated goal behind the requirement ("a strip of the same kind never looks identical") is met, since geoVariant still varies decor within a kind. What is missing is the per-kind split that would make a Studio read as a different class of room from an Apartment at a glance.

Fix when picked up: split RENTAL_PICTURES into a Studio set and an Apartment set. Touches sprites, so it drifts the gallery and needs a pinned-container screenshot refresh.

/gds-code-review.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/render/pixelSprites/residential.looks.ts and src/render/pixelSprites/residentialRentalSprites.ts, comparing the Studio and Apartment wall and picture-set assignments. Split RENTAL_PICTURES into distinct Studio and Apartment sets while preserving geoVariant variation. Confirm the gallery output and refresh the pinned-container screenshot because the sprite change affects them.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.