maniator / maniator/verticopolis
[P3] rental-star-coupling-untested: Epic 7's star half has no test
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Deferred from the /gds-code-review Acceptance Auditor on PR #633 (Modern rental living, v2.0.0).
Epic 7's done-when reads: "a tower that loses an Apartment floor shows a population/star dip that recovers on re-lease, a Studio-only tower's stars stay stable through scrappy conditions, and a test pins both."
Only the population half is pinned. src/engine/rentalLiving.test.ts:345-355 asserts a population delta; star appears in that file only as fixture setup (lines 35, 63-68). There is no star-dip test, no recovery-on-re-lease test, and no Studio-stability test anywhere in the branch.
The behavior is believed correct (rentals feed the same population census the star rating reads), so this is a coverage gap rather than a known defect. It is filed because the epic explicitly asked for the test and the epic was marked complete.
Fix when picked up: add the two assertions Epic 7 names.
/gds-code-review.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/engine/rentalLiving.test.ts, especially the existing population assertion at lines 345-355 and the star fixtures at lines 35 and 63-68. Run the rental living tests, then add coverage for the Apartment star dip and recovery on re-lease plus Studio-only star stability. Done means the Epic 7 star behavior is pinned by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100