maniator / maniator/verticopolis

[P3] schedule-esc-announcement: pressing Esc announces nothing to a screen reader

Open Beginner friendly
#670 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Deferred from /bmad-code-review of the pinned dialog footer (PR #664, v1.104.0). Edge Case Hunter finding.

In src/ui/templates/elevatorSchedule.ts the unsaved-changes warning renders on state.dirty, and arming the discard guard with Esc only flips its role from status to alert. The node and its text are unchanged, so nothing is announced: a live region announces content changes, not attribute changes.

A screen-reader user therefore presses Esc, has the press absorbed by the guard, and receives no feedback that anything happened. That is the same shape as the bug #664 fixed for sighted players (feedback rendered where it cannot be perceived), just on a different channel.

Fix when picked up: change the warning's text when the guard arms, so the live region has something to announce, e.g. naming the second press as the one that discards. Assert the text changes on arming rather than asserting the role attribute.

/bmad-code-review.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/ui/templates/elevatorSchedule.ts and trace the unsaved-changes warning rendered from state.dirty, including the Esc discard guard. Change the warning text when the guard arms so the live region announces that a second press will discard, then update or add the relevant assertion to verify the text changes rather than the role attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.