maniator / maniator/verticopolis

[P3] crash-card-actions-below-fold: the crash card's buttons can sit below the fold with Esc suppressed

Open Beginner friendly
#668 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Deferred from /bmad-code-review of the pinned dialog footer (PR #664, v1.104.0). Edge Case Hunter finding.

The pinned-footer rule added in #664 is scoped to .modal-box > .modal-actions, so the crash card (src/ui/crashScreen.ts) is not covered by it. On a short or landscape phone its Reload / Download buttons can fall below the fold, and the crash card deliberately suppresses Esc, so a player who cannot reach the buttons has no way out of it.

This is the same failure #664 fixed for dialogs, on the one surface where the fallback is worst: it is already the screen the player lands on when something has gone wrong.

Fix when picked up: give the crash card the same sticky treatment. It is not a .modal-box, so it needs its own rule rather than an extension of the dialog selector. Add a capture at a short viewport, following the pattern of the shots #664 added.

/bmad-code-review.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/ui/crashScreen.ts and compare the crash card with the pinned-footer treatment from PR #664. Apply the crash card’s own sticky rule, then check it at a short or landscape phone viewport. Done means the Reload and Download buttons remain reachable despite Esc being suppressed, with a capture following the shots from #664.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.