maniator / maniator/verticopolis
[Bug]: [P3] pr-drift-check render filter misses scripts/scenes/*.ts (a scene-only edit can merge a stale gallery)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
From the Edge Case Hunter review of dropping the excalibur-preview screenshot scene (/bmad-code-review, 2026-07-15), folded from the deferral inbox by #545. No drift-workflow row existed.
pr-drift-check.yml's changes job classifies render-affecting edits with a scripts/screenshot-*.ts glob, which does not match scripts/scenes/*.ts. A future scene-only edit (adding or changing a shot without co-editing scripts/screenshot-shards.ts or another screenshot-*.ts file) could skip the screenshot drift capture and merge a stale gallery. Fix: widen the filter to include scripts/scenes/** (or scripts/screenshot* and scripts/scenes together).
Low severity, watch-only until a scene-only PR actually lands. Tooling/CI (/bmad-code-review).
Tracked as backlog row pr-drift-check-scenes-glob; folded from the deferral inbox by #545.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the changes job in pr-drift-check.yml and inspect the render-affecting path filter. Verify how a change under scripts/scenes/ is classified, then broaden the filter as described and confirm that a scene-only edit triggers screenshot drift capture rather than allowing a stale gallery.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100