maniator / maniator/verticopolis

[Bug]: [P3] Thief cosmetic can play fully off-screen

Open
#337 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Imported from the engineering backlog (_bmad-output/implementation-artifacts/backlog.md, story event-visuals).
Priority P3 (do-first order) | Severity: low (cosmetic) | Status: open | Epic: — | Type: review-deferral | Recorded: 2026-07-06

What happened?

Ready. Thief cosmetic can play fully off-screen. TowerEngine.renderThief anchors the thief's Y to a random tenanted floor (worldToScreenY(thiefFloor)); in a tall tower that floor is often outside the viewport, so the run animates invisibly (regression from the old always-visible viewHeight*0.66). Accepted tradeoff of grounding the thief on a real floor + the engine/render separation (the engine can't know the camera), and the player still gets the log/toast line. If it reads as "missing the cosmetic," bias selection toward the lobby / a low floor (like the VIP limo), or nudge the camera to the thief's floor for the run. (gds-code-review, thief-grounding: Blind + Edge Case Hunter.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at TowerEngine.renderThief and trace how thiefFloor feeds worldToScreenY; compare that path with the former viewHeight*0.66 anchor. Check the event-visuals story and VIP limo/lobby selection context, then confirm the chosen visibility behavior in a tall tower. Done means the thief cosmetic is not allowed to animate entirely outside the viewport.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.