mangui / mangui/flashls

Videojs: 0.4.1.1: hls_capleveltostage default value appears to be "true", not "false"

Open
#356 1 comment 0 reactions 0 assignees View on GitHub
help wanted videoJS
Dominant language
ActionScript
Stars
744
Forks
259
PR merge metrics
No merged PRs in 30d

Description

While working on #351, @hparra recommended I set hls_capleveltostage=false to fix the issue, which worked! The odd thing is that the [documentation](https://github.com/mangui/flashls/blame/dev/README.md#L104) says the default value for hls_capleveltostage is false, and a quick scan of the [source code](https://github.com/mangui/flashls/blob/dev/src/org/mangui/hls/HLSSettings.as#L21) says the same thing.

I've made 3 demo pages:
- [hls_capleveltostage=default value](http://rawgit.com/tommyh/b7af90c10cd8b63892fe/raw/3a35a8c4d73262f8c5cfa76081cf56888a25b4e8/hls_capleveltostage_default.html) (ie not set by the client)
- [hls_capleveltostage=true](http://rawgit.com/tommyh/b7af90c10cd8b63892fe/raw/3a35a8c4d73262f8c5cfa76081cf56888a25b4e8/hls_capleveltostage_true.html)
- [hls_capleveltostage=false](http://rawgit.com/tommyh/b7af90c10cd8b63892fe/raw/3a35a8c4d73262f8c5cfa76081cf56888a25b4e8/hls_capleveltostage_false.html)

I see the same behavior for capleveltostage=default and capleveltostage=true. Which from an outsiders perspective makes it feel that the actual default is true. Is there something I'm misunderstanding here? Or is there an issue where the default value in the actionscript code isn't actually getting picked up and the default value actually is true?

Note: when I say "same behavior" for the demo page, notice which level takes the stage. for capleveltostage=true/default you get the 64k-audio, but for the capleveltostage=false you get the 2040K-video.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked README.md entry and src/org/mangui/hls/HLSSettings.as, then compare the three linked demo pages for the unset, true, and false values. Verify which value is actually used when the client omits hls_capleveltostage and determine whether the documented default matches the observed stage selection.

Written by the indexing model from the issue text.

Assessment

Domain
audio-video-rtc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.