mangui / mangui/flashls

Stage

Open
#152 7 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
ActionScript
Stars
744
Forks
259
PR merge metrics
No merged PRs in 30d

Description

Hello Guillaume,

First of all, thank you for your work.
I have question/proposition about Stage object. HLS class is very depended on Stage, but It's just a setter.
I recommend to move [Stage initialization](https://github.com/mangui/flashls/blob/81ecd8ce8b2ecd1f717d18b2a9168a3c7fa14837/src/org/mangui/hls/HLS.as#L174) in more important method. Anyway, with current implementation, library doesn't work without Stage. Or check for `Stage` could be earlier, before HTTP request to manifest.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Stage initialization linked in src/org/mangui/hls/HLS.as around line 174, then trace how HLS uses Stage before requesting the manifest. Compare the proposed initialization timing with an earlier Stage check, and verify that the library handles operation without Stage before any HTTP request.

Written by the indexing model from the issue text.

Assessment

Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.