mandiant / mandiant/macos-UnifiedLogs
A lot more anti-panicking code
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 376
- Forks
- 43
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 8
Description
Once #139 is merge, should we activate a few lints in Cargo.toml :
[lints.rust]
unsafe_code = "deny"
[lints.clippy] # see also clippy lints configurations in file : `clippy.toml`
unwrap_used = "deny"
expect_used = "deny"
indexing_slicing = "deny"
panic = "deny"
suppress-restriction-lint-in-const = true
# https://rust-lang.github.io/rust-clippy/master/#expect_used
allow-expect-in-tests = true
# https://rust-lang.github.io/rust-clippy/master/#unwrap_used
allow-unwrap-in-tests = true
# https://rust-lang.github.io/rust-clippy/master/#/indexing_slicing
allow-indexing-slicing-in-tests = true
# https://rust-lang.github.io/rust-clippy/master/?levels=allow#panic
allow-panic-in-tests = true
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
After #139 is merged, start with Cargo.toml and clippy.toml and review the proposed Rust and Clippy lint settings. Run the project's Clippy checks to identify existing violations, then confirm the lints can be enabled with the documented test allowances and that the checks pass cleanly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100