mandiant / mandiant/gocrack

sorting cracked passwords by "cracked_at" yields unexpected results

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
1.3k
Forks
238
PR merge metrics
No merged PRs in 30d

Description

If you're on the Cracked Passwords page for a Task and try to sort the passwords via the `cracked_at` column, the results will be incorrect. This is caused by the boltdb/storm storage backend as the data is stored as JSON. Storm doesn't have the concept of ordering by time.Time objects that come out after a document is decoded

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Cracked Passwords page and the sorting path for the `cracked_at` column, then inspect how the boltdb/storm backend stores and orders decoded JSON values. Reproduce the incorrect ordering with passwords containing different times; done means sorting by `cracked_at` returns chronological results.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.