don't assign function names when FLIRT signatures conflict
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.2k
- Forks
- 726
- Avg merge
- 11d 11h
- Merged PRs (30d)
- 7
Description
as described in #656, different signature sets may match on the same function with different names. in this scenario, we don't know which signature name to trust, so i propose that we should not assign a function name.
note that due to the work in #656, the signature sets do load deterministically, so we'll get consistent results. but, they may not be perfectly accurate (first write wins).
this would take a little work within the viv-utils FLIRT matcher but should be doable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the FLIRT matcher work in viv-utils and the deterministic signature-loading context from #656. Trace how conflicting names are handled for one function; done means a function with conflicting matching signatures receives no assigned name while consistent matches retain their names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- reverse-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100