mandiant / mandiant/VM-Packages
Hashcat Failure Due to Processor Check
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 246
- Forks
- 98
- Avg merge
- 9h 30m
- Merged PRs (30d)
- 7
Description
The hashcat package will fail if the system's processor is not "GenuineIntel", see below:
https://github.com/mandiant/VM-Packages/blob/eac039ddb9852d3cc155a400895de4bebeb1ccfc/packages/hashcat.vm/tools/chocolateyinstall.ps1#L20-L26
However, the GitHub actions to test installation may use non-GenuineIntel processors and the package will fail. Since we cannot guarantee the processor type during the test installation, I propose we complete the installation and raise a warning to the user that their system does not support this tool due to a non-GenuineIntel processor.
This allows the test suite to recognize a successful installation and will reduce confusion as to why the package is failing.
@mandiant/commando-vm thoughts since this is mainly a Commando VM tool?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/hashcat.vm/tools/chocolateyinstall.ps1 at the processor check on lines 20-26, then review how the GitHub Actions installation test reports failure. Done means installation succeeds on non-GenuineIntel processors while warning that hashcat is unsupported there, allowing the test suite to recognize a successful installation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100