mandiant / mandiant/VM-Packages

Do not retry package installation on reboot

Open
#1,378 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:bug: bug :grey_question: discussion
Dominant language
PowerShell
Stars
246
Forks
98
Avg merge
9h 30m
Merged PRs (30d)
7

Description

### Details

As @vsl-iil mentioned in https://github.com/mandiant/flare-vm/issues/577, at the moment our installer tries to reinstall failed packages when a reboot occurs. This is because how the installer is implemented and it is annoying for packages that are broken. Ideally, we want to re-try failed packages installation once after installing all packages (https://github.com/mandiant/VM-Packages/issues/1219), but not on every reboot. This makes that packages that are installed earlier are re-tried many more times. I am not sure if there is a way to avoid packages to get reinstalled, @mandiant/vms any ideas?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the installer behavior described here and the linked discussions in FLARE-VM issue 577 and VM-Packages issue 1219. Trace the package installation and reboot handling entry points, then verify that failed packages are not retried on each reboot and that the intended single retry after all packages are installed remains possible.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.