mandiant / mandiant/VM-Packages
Improve VM-Uninstall-With-Uninstaller & fix uninstallation of packages using this function
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 246
- Forks
- 98
- Avg merge
- 9h 30m
- Merged PRs (30d)
- 7
Description
### Details
`VM-Uninstall-With-Uninstaller` uninstall the tool and removes the shortcut, but it does not remove the tool files (usually, but not always, in `C:\Tools`). Because of that some packages seem to call `VM-Uninstall` after calling `VM-Uninstall-With-Uninstaller`. @mandiant/vms there any other reason to call `VM-Uninstall`? We should add the removal of tool files (and anything else needed) to `VM-Uninstall-With-Uninstaller` to remove the unneeded extra call to `VM-Uninstall`.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the VM-Uninstall-With-Uninstaller and VM-Uninstall functions and inspect the package calls that use them. Verify which cleanup removes the tool files and shortcut, then confirm that VM-Uninstall-With-Uninstaller handles the required cleanup without an extra VM-Uninstall call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100