mandiant / mandiant/VM-Packages
remove microsoft-windows-terminal.vm exclusion in CI
Open
@emtuls is already working on this.
Since Jan 9, 2025.
:gem: enhancement
- Dominant language
- PowerShell
- Stars
- 246
- Forks
- 98
- Avg merge
- 9h 30m
- Merged PRs (30d)
- 7
Description
Details
We renamed microsoft-windows-terminal.vm to windows-terminal.vm in https://github.com/mandiant/VM-Packages/pull/936. We had excluded this package from the 2019 test because it was failing: https://github.com/mandiant/VM-Packages/blob/main/.github/workflows/ci.yml#L47, but we forgot to rename the exclude package, which means the package seems to install correctly in 2019 and the exclusion doesn't seem to be needed anymore. Or am I missing something?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.