mandiant / mandiant/VM-Packages

Move Removal of `map.vm` Right Click "Cmd Here" option from "map.vm" to "windows-terminal.vm"

Open
#1,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:cyclone: FLARE-VM :gem: enhancement :grey_question: discussion
Dominant language
PowerShell
Stars
246
Forks
98
Avg merge
9h 30m
Merged PRs (30d)
7

Description

### Details

As of https://github.com/mandiant/VM-Packages/pull/983, we opted to remove the right click "Cmd Here" that `map.vm` introduces when installing due to favoring the right click for opening with `Windows Terminal` instead.

But, we placed this removal code inside of the `map.vm` package, which means that if a user wants `map.vm` and wants to retain this right click option, but does not add `windows-terminal.vm` to their list of packages, they would have no Right Click "Cmd Here" option available to them automatically.

I think the removal of the Right Click "Cmd Here" added by `map.vm` is better suited inside of the `windows-terminal.vm` package, as that is where we are essentially replacing the right click option, and would give uses the ability to keep the one added by `map.vm` if they wanted to only use that package.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the package definitions in map.vm and windows-terminal.vm, focusing on the code that removes the right-click "Cmd Here" option. Move responsibility for that removal to windows-terminal.vm so installing map.vm alone retains its option, while installing windows-terminal.vm provides the replacement behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.