symtab assigned on error instead of successful parse?

Nobody has claimed this yet.

Hi,

I'm a software engineer currently working on Go binary analysis, and while reviewing the code I noticed what might be a logic issue in objfile/pe.go around line 180.

send_tab := func(candidate *PclntabCandidate) {
if symtab_err != nil {
candidate.Symtab = symtab
ch_tab <- *candidate
}
ch_tab <- *candidate
}

From my understanding, symtab should be assigned to candidate.Symtab when parsing succeeds (symtab_err == nil), not when an error occurs.

Currently, the code assigns the parsed symtab only when symtab_err != nil, which seems unexpected. As a result, when parsing succeeds, candidate.Symtab is never populated.

Would the following logic be more appropriate?

if symtab_err == nil {
candidate.Symtab = symtab
}

Additionally, it looks like ch_tab <- *candidate is executed twice when symtab_err != nil, causing the same candidate to be sent twice. Is this intentional?

I may be missing some context, so I wanted to ask before submitting a patch.

Thanks!

Start in objfile/pe.go around line 180 and inspect the send_tab closure, including both symtab_err handling and ch_tab sends. Verify the candidate is populated only for a successful parse and is not sent twice on an error; confirm the relevant Go tests or checks pass.

Written by the indexing model from the issue text.