mancj / mancj/SlideUp-Android

Sideways sliding using incorrect sliding distance

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.6k
Forks
207
PR merge metrics
No merged PRs in 30d

Description

When using either an START or END gravity, the user must ensure that the layout height is greater than (or equal to) the layout width for this library to work. My suspicion is that the layout_height attribute is used as the sliding distance even when a sideways orientation is specified.

Without delving into the code in this library, this assumption is backed up by looking at the sliding velocity with a layout with a small width and tall height when it is hidden - it leaves the screen very rapidly without the correct interpolation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with START and END gravity using layouts whose width and height differ, and compare the hidden-state sliding velocity and interpolation. Inspect how the library selects sliding distance for sideways orientation; done when sideways motion uses the relevant layout dimension and reaches the expected hidden position at the correct speed.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.