mancj / mancj/MaterialSearchBar
Not able to check if the suggestion list is shown or not.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 324
- PR merge metrics
- No merged PRs in 30d
Description
- You have a method to check to show suggestions and hide suggestions but you don't have a method to check if the Suggestion list is currently hidden or shown.
searchBar.showSuggestionsList();
searchBar.hideSuggestionsList();
It will be very helpful if there was a method to check if the list was open or closed. isSuggestionsListOpen().
This is because of the fact that you close the list when user clicks the keyboard button submit. Then after than whenever I try to search again, the list never comes up until i explicitly do searchBar.showSuggestionsList();. I cannot call this method always as the list flickers when i call this.
A method such as isSuggestionsListOpen() will surely help in knowing if list is present or not on the screen.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing searchBar.showSuggestionsList() and searchBar.hideSuggestionsList() methods and how the keyboard submit action closes the list. Add a query for the current suggestion-list visibility, then verify that searching again can use the state without causing the list to flicker.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100