managed-components / managed-components/google-ads

Put all custom fields in the `data` query parameter automatically

Open
#1 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue PRs welcome
Dominant language
TypeScript
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

We would like to send custom fields set in the Zaraz remarketing tool interface to Google Ads and are wondering wether `payload.data` is the variable holding the custom fields content:

https://github.com/managed-components/google-ads/blob/98a05f12bb63a419bec39df26378a127e32b84d7/src/index.ts#L106

Is this correct? Is this line the part where the custom fields get merged in the parameters?

We are expecting to see custom field data set as parameters in Google ads in the segment creation section in Audiences as follows:

![Screenshot 2023-05-10 at 6 41 11 pm](https://github.com/managed-components/google-ads/assets/11142114/ebd60208-e60b-4ff7-940e-eaba77b0bf54)

For some reason we do not receive the custom field value as a custom parameter to use in creating custom segment in Google Ads. What could be the reason? Could you give an example of how the URL looks like with custom fields?

Thank you very much indeed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/index.ts line 106 and inspect how payload.data is used when Google Ads parameters are assembled. Reproduce the request with custom fields from the Zaraz remarketing interface, then determine whether those fields reach the generated URL; done should include a confirmed explanation or a defined change for passing them through.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.