man-group / man-group/notebooker
Notebooker Windows Issues
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 939
- Forks
- 95
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 1
Description
Love the project and concepts but having a few issues in getting this up and running on windows 11
1) In window virtual env the executable notebooker-cli is in the script folder so
https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/execute_notebook.py#L522
should be replaced by
os.path.join(sys.exec_prefix, "Scripts", "notebooker-cli")
2) Babel needs a locale defined
https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/utils/results.py#L147
should be replaced by
metadata["time_diff"] = babel.dates.format_timedelta(datetime.datetime.now() - metadata["latest_run"], locale = "en")
3) open statements should include encoding="utf-8")
https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/execute_notebook.py#L117
https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/utils/conversion.py#L27
i.e. open(ipynb_path, "r", encoding="utf-8")
4) this still appears to be an issue with a blank results page output
https://github.com/man-group/notebooker/issues/77#issuecomment-1062321017
this returns an empty array
http://127.0.0.1:11828/core/get_all_available_results?limit=100&report_name=sample/plot_random
but this works... it is to do with slashes
http://127.0.0.1:11828/core/get_all_available_results?limit=100&report_name=sample\plot_random
I couldnt work out where best to fix this... any advice.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with notebooker/execute_notebook.py and notebooker/utils/results.py, then inspect notebooker/utils/conversion.py for the Windows virtual-environment, locale, and UTF-8 issues described. Trace the core/get_all_available_results endpoint for the slash-dependent empty response, using issue 77's discussion as context. Done means these reported Windows startup and results-page problems are resolved and the endpoint returns results for the stated report name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook, python
- Domain
- api, backend, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100