man-group / man-group/mdf

mdf run() fails to incorporate tzinfo when passed a pandas.DateRange

Open
#13 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
183
Forks
54
PR merge metrics
No merged PRs in 30d

Description

pandas.DateRange is deprecated. If run() is passed a date_range parameter constructed from pandas.DateRange it will actually be of time DatetimeIndex. Consequently run() fails to extract tzinfo from date_range since it checks to see if date_range has type pandas.DateRange first. The workaround is to pass in a tzinfo parameter explicitly to run(). The fix should be to remove the dependence on pandas.DateRange.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the run() implementation and inspect how its date_range parameter checks for pandas.DateRange before extracting tzinfo. Reproduce the issue with a pandas DatetimeIndex created from a date range, then verify that timezone information is handled without requiring an explicit tzinfo parameter.

Written by the indexing model from the issue text.

Assessment

Tech stack
pandas, python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.