maliput / maliput/maliput_object

BoundingRegion: Tolerance argument in the methods

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
api discussion
Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

### Context

Comes from [this ](https://github.com/ToyotaResearchInstitute/maliput_object/pull/7#discussion_r861682305) PR comment.

`BoundingRegion` api doesn't know about tolerance. In the first implementation that we have, `BoundingBox` asks for tolerance in its constructor.

Question is, would it be better to request tolerance only in the methods? This will imply recognizing from the BoundingRegion's api that tolerance is requested when calling the methods.

Probably the most related use-case is that this package in general, `maliput` will be used and when objects are being constructed there won't be possible to call `maliput::api::RoadGeometry::linear_tolerance()` in order to match tolerances, as probably the RoadNetwork won't be ready to be queried yet.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the discussion linked from PR #7 and the BoundingRegion and BoundingBox APIs mentioned in the issue. Determine whether tolerance belongs in BoundingRegion methods rather than construction, and document the chosen API behavior and matching tolerance expectations as the definition of done.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.