maliput / maliput/maliput_multilane

Multilane Technical debt - Missing tests

Open
#8 0 comments 0 reactions 1 assignee View on GitHub

@agalbachicar is already working on this.

Since Jun 4, 2019.

Dominant language
C++
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The following TODOs in code are there to remember addressing tests / modifying tests:

- [ ] [multilane_builder_test.cc:23](https://github.com/RobotLocomotion/drake/blob/master/automotive/maliput/multilane/test/multilane_builder_test.cc#L23) --> Trivial.
- [x] [multilane_loader_test.cc:42](https://github.com/RobotLocomotion/drake/blob/master/automotive/maliput/multilane/test/multilane_loader_test.cc#L42) and [multilane_loader_test.cc:45](https://github.com/RobotLocomotion/drake/blob/master/automotive/maliput/multilane/test/multilane_loader_test.cc#L45) --> Trivial.
- [x] [multilane_loader_test.cc:549](https://github.com/RobotLocomotion/drake/blob/master/automotive/maliput/multilane/test/multilane_loader_test.cc#L538) --> implies creating a Group interface and then refactoring that test.
- [ ] [multilane_types_compare.h](https://github.com/RobotLocomotion/drake/blob/master/automotive/maliput/multilane/test_utilities/multilane_types_compare.h#L31) --> here and there are functions that compare different coordinates with the same tolerance, e.g. EndpointXy. A general review of tolerances for linear, angular and derivative values needs to be done. (#9239)

This ticket is a copy of: https://github.com/RobotLocomotion/drake/issues/8899

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.