maliput / maliput/maliput_multilane
Split builder.h
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Downstream, projects would indirectly include `builder.h` because of including `loader.h`. Currently, several utility classes are there to express their unique purpose of help `BuilderBase` implementations. That leads to extra unnecessary code declarations duplicated in all imported targets.
A simple split of `builder.h` that would significantly improve with little change is to move class implementations (not the base libraries) to builder.cc files.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with builder.h and identify the utility class implementations described in the issue, then inspect the corresponding builder.cc files and the targets that include loader.h. Move only the implementations, not the base libraries, and verify that affected targets no longer receive unnecessary declarations and still build successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100